Skip to content

Add open_bucket_dialog script API selecting bucket files#2954

Merged
jmthomas merged 6 commits intomainfrom
open_bucket
Mar 14, 2026
Merged

Add open_bucket_dialog script API selecting bucket files#2954
jmthomas merged 6 commits intomainfrom
open_bucket

Conversation

@jmthomas
Copy link
Copy Markdown
Member

@jmthomas jmthomas commented Mar 7, 2026

Adds a new scripting API method that presents a dialog similar to Bucket Explorer, allowing users to browse S3 buckets and select a file. Returns a file object identical to open_file_dialog. Includes Ruby/Python backends, Vue frontend dialog, API docs, demo procedures, and Python type stubs.

closes #2013

…iles

Adds a new scripting API method that presents a dialog similar to Bucket Explorer,
allowing users to browse S3 buckets and select a file. Returns a file object
identical to open_file_dialog. Includes Ruby/Python backends, Vue frontend dialog,
API docs, demo procedures, and Python type stubs.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@jmthomas jmthomas requested review from ryan-pratt and ryanmelt March 7, 2026 23:46
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2026

Codecov Report

❌ Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.45%. Comparing base (c2da961) to head (0dc6552).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/script/script.rb 14.28% 6 Missing ⚠️
openc3/lib/openc3/script/storage.rb 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2954      +/-   ##
==========================================
- Coverage   78.51%   78.45%   -0.06%     
==========================================
  Files         673      673              
  Lines       55332    55346      +14     
  Branches      728      728              
==========================================
- Hits        43445    43424      -21     
- Misses      11809    11844      +35     
  Partials       78       78              
Flag Coverage Δ
python 79.74% <ø> (-0.02%) ⬇️
ruby-api 80.48% <100.00%> (-0.46%) ⬇️
ruby-backend 82.12% <25.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +2469 to +2472
let answer = 'Cancel'
if (response !== 'Cancel') {
answer = response
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Copy Markdown
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved when storage.py deleted.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
4.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@jmthomas jmthomas merged commit 628749e into main Mar 14, 2026
51 of 52 checks passed
@jmthomas jmthomas deleted the open_bucket branch March 14, 2026 19:00
jmthomas added a commit that referenced this pull request Mar 21, 2026
Add open_bucket_dialog script API selecting bucket files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

object browser similar to open_file_dialog

3 participants